Provide optional parameters to Countries #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think public holidays are based on someone's ethnic? |
|
I don't really like this approach, so closing this one. Thanks for your work anyway! |
|
@Nielsvanpach Ethnic group is only one of possibilities of this PR, and if it is given by government as discussed in thread mentioned in original PR message, it is valid to have ethnical based holidays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to provide any required parameters to countries models like region, ethnical type, ...
This PR was created by discussion about North Macedonia holidays Thread here so NorthMacedonia has some preparations made, which will be updated by its contributor
This PR also updating French model and test, as there was problem with custom France constructor just to use region (now it uses global one.