Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Colombian Holidays for 2024 #172

Closed
wants to merge 2 commits into from
Closed

Add Colombian Holidays for 2024 #172

wants to merge 2 commits into from

Conversation

juancho48
Copy link

@juancho48 juancho48 commented Jan 23, 2024 •
edited
Loading

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?
  1. Created Colombia.php Class
  2. Addded ColombiaTest.php
  3. Ran the tests so a snapshot was created.
  4. Verify the result in the newly created snapshot is correct.

@luisprmat
Copy link

Hi @juancho48, for this same purpose the PR#55 was created. This also works for the years from 1984 to 2037 and not only for 2024.

You are welcome to review that PR and make any suggestions you consider necessary to improve it.

@juancho48 juancho48 closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancho48 @luisprmat @juan-arkideas