Feature/switzerland with regions #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: matusk <[email protected]>
Co-authored-by: matusk <[email protected]>
Co-authored-by: matusk <[email protected]>
Co-authored-by: matusk <[email protected]>
not using this for country and year either
Add Slovakia holidays
Add support for multi languages
Add latvian holidays
* Adding Colombia Holidays Added the Colombia's holidays. There's a situation with some holidays due to the "Emiliany Law" they are moved to the following monday. * Adding Colombia Holidays Added the Colombia's holidays. There's a situation with some holidays due to the "Emiliany Law" they are moved to the following monday. * Update Colombia.php Deleted the line as suggested by @Nielsvanpach * Update Colombia.php * Added changes to Colombia.php and to the test file - Suggestions from @luisprmat were incorporated. - All the work of emiliani holiday generation was included into the emilianiHoliday method to achieve code readability - The order of the holidays was updated to ensure that the next emiliani holiday that appears can be included at the end of the list. - The test was updated because it's "colombian holidays" not "colombia holidays"
* Add holidays for Finland * Use createFromDate instead of create * Add holidays for Finland in Swedish
* Add Japan country support * Tested: it can calculate japanese holidays → Snapshot created
* Add Serbian holidays * Calculate orthodox easter * Improve phpstan * Fix test * Expand list with Christmas and Easter
* add El Salvador holidays * fix styling
…into feature/switzerland-with-regions # Conflicts: # src/Countries/Switzerland.php # tests/Countries/SwitzerlandTest.php
|
I think something went wrong with rebasing, there shouldn't be commits of others in this PR |
Oh gosh yes. I was too tired yesterday to fix it xD. Very sorry you have to witness this massacre |
|
Thanks for your work, but a PR for Switzerland has already been merged. Feel free to send a new PR with fixes to the current implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: Switzerland with cantons (regions)
this proof of concept is extending @Martin-Welte's work #49.
Additional information
this pull request adds:
i hope i can get some feedback whether either of the implementations are considered valid to move forward or adapt?