[ADD] sudan public holidays #179

Mazin-Ibrahim · 2024-01-25T08:58:36Z

Contributing a new country ?

Have you checked to ensure there aren't other open Pull Requests for the same country?

Create a new class in the Countries directory. It should extend the Country class.
Add a test for the new country in the tests directory.
Run the tests so a snapshot gets created.
Verify the result in the newly created snapshot is correct.

Nielsvanpach · 2024-01-31T19:43:26Z

src/Countries/Sudan.php

+     */
+    private function variableHolidays(int $year): array
+    {
+        return [];


This is how other countries solved the Islamic holidays: https://github.com/spatie/holidays/blob/main/src/Countries/Turkey.php#L8

Nielsvanpach · 2024-03-22T15:15:38Z

Thanks for your effort, but I'm closing this PR as the Islamic holidays are missing.
Feel free to reopen if you decide to continue this PR!

Mazin-Ibrahim added 2 commits January 25, 2024 11:56

[ADD] sudan public holidays

eb23f4d

[FIX] issues sudan public holidays

c048cce

Nielsvanpach reviewed Jan 31, 2024

View reviewed changes

Nielsvanpach closed this Mar 22, 2024