Add Jordan holidays

[yousefdev20]

Contributing a new country ?

• Have you checked to ensure there aren't other open Pull Requests for the same country?

1. Create a new class in the Countries directory. It should extend the Country class.
2. Add a test for the new country in the tests directory.
3. Run the tests so a snapshot gets created.
4. Verify the result in the newly created snapshot is correct.

[Nielsvanpach]

Can you use class consts for this? Have a look at Egypt or Bahrain

[yousefdev20]

@Nielsvanpach
Why I used this approach:

1. It's hard to read around 200 lines of code to read the elements.
2. in some countries the holidays are shared or in the same region.
3. at the end the Islamic directory is loadable.

[Nielsvanpach]

2 and 3 seem valid points.

Although, using jo as a key doesn't feel like the way to go for being shareable across countries?

Also, if you have a look at Turkey, I prefer that format. What the benefit of using the extra date key?

Also, for multiday holidays it's possible to have it twice in a single year:

1999 => '01-19',
2000 => [
    '01-08',
     '12-27',
],

[yousefdev20]

jo it may change,

date is more readable,

The third note is valid.

[Nielsvanpach]

We already have an IslamicCalendar trait which you can use

[yousefdev20]

This trait depends on the constants variable and I explained the issue in the above replay.

[Nielsvanpach]

I think the Observable trait is what you need

[spatie-bot]

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.