Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Australian Holidays #43

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Add Australian Holidays #43

merged 5 commits into from
Jan 25, 2024

Conversation

patrickomeara
Copy link
Contributor

@patrickomeara patrickomeara commented Jan 17, 2024

These are the national holidays down to the state level.

@patrickomeara patrickomeara force-pushed the main branch 2 times, most recently from eb6f4cc to 8b2b951 Compare January 17, 2024 21:50
src/Countries/Australia.php Outdated Show resolved Hide resolved
@patrickomeara patrickomeara force-pushed the main branch 4 times, most recently from 29b35f2 to 2234633 Compare January 18, 2024 23:31
These are the national holidays, that all states observe.
@patrickomeara patrickomeara force-pushed the main branch 2 times, most recently from c243974 to b00b128 Compare January 22, 2024 00:48
@Nielsvanpach
Copy link
Member

Thanks! I'll leave this open until this has some approvals by others.

Copy link

@samlev samlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me without going into the absolute absurdity that is "replacement public holidays" (i e. those certain public holidays that fall on a weekend so some states give a "replacement" public holiday on the following Monday)

@patrickomeara
Copy link
Contributor Author

Thanks @samlev I did think about the replacement days but decided against implementing something at this stage. The context of how the package is being used is a big factor to whether replacement days are useful or not.

@patrickomeara
Copy link
Contributor Author

The tests seem a little flaky, when running all the tests locally I get between 1 and 3 fails. Uganda, Estonia and North Macedonia.

@Nielsvanpach
Copy link
Member

Thanks, PR looks good! I'll have a look at the failing tests.

@Nielsvanpach Nielsvanpach merged commit 7f169c0 into spatie:main Jan 25, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants