Add Australian Holidays #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickomeara
force-pushed
the
main
branch
2 times, most recently
from
eb6f4cc to
8b2b951
Compare
samlev
reviewed
Jan 18, 2024
patrickomeara
force-pushed
the
main
branch
4 times, most recently
from
29b35f2 to
2234633
Compare
These are the national holidays, that all states observe.
patrickomeara
force-pushed
the
main
branch
2 times, most recently
from
c243974 to
b00b128
Compare
|
Thanks! I'll leave this open until this has some approvals by others. |
samlev
approved these changes
Jan 22, 2024
|
Thanks @samlev I did think about the replacement days but decided against implementing something at this stage. The context of how the package is being used is a big factor to whether replacement days are useful or not. |
patrickomeara
commented
Jan 22, 2024
|
The tests seem a little flaky, when running all the tests locally I get between 1 and 3 fails. Uganda, Estonia and North Macedonia. |
|
Thanks, PR looks good! I'll have a look at the failing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the national holidays down to the state level.