Add support for Slovenian holidays #48
Conversation
|
Maybe we could add a new method beside
In both options, we would need to add a translation file or reference array. |
src/Countries/Slovenia.php
Outdated
| { | ||
| return array_merge([ | ||
| 'Novo leto' => '01-01', // New Year's Day | ||
| 'Novo leto 2' => '02-01', // New Year's Day, yes it's a second day |
There was a problem hiding this comment.
This should be 01-02 if the day is January 2nd, right?
There was a problem hiding this comment.
Thank you for noticing. In out country the default is DD-MM that's why I accidentally put it this way.
| }, | ||
| { | ||
| "name": "Novo leto 2", | ||
| "date": "2024-02-01" |
I'm open to accept a good PR which implements translations. #131 |
src/Countries/Slovenia.php
Outdated
| return 'si'; | ||
| } | ||
|
|
||
| /** @return array<string, CarbonImmutable> */ |
src/Countries/Slovenia.php
Outdated
| /** @return array<string, CarbonImmutable> */ | ||
| protected function variableHolidays(int $year): array | ||
| { | ||
| $easter = CarbonImmutable::createFromTimestamp(easter_date($year)) |
There was a problem hiding this comment.
use $this->easter($year) instead. Only available if your branch is rebased on the repo's main branch.
implementation returned bad dates
…hat Great Prayer Day is no longer a public holiday in 2024.
* removed comments
* Add support for Irish public holidays * Add logic that St Brigid's only started from 2023 * Add tests for St Brigid's Day St Brigids Day is a new holiday in 2023 and it is variable so adding tests around the logic * Apply PSR12 formatting
* adds croatian holidays * stan fixes * fixed allHolidays return type
* feature: add bolivian holidays * test: add bolivia test * test snap * fixed typo and phpstan * calculate correct easter date * Fix styling --------- Co-authored-by: rats4final <[email protected]> Co-authored-by: rats4final <[email protected]>
* Add Estonian holidays * Use easter() method for easter date
|
Something seem to went wrong with rebasing. Could you make a clean PR with only commits related to Slovenia? Thanks! |
|
Sure, no problem. |
|
New PR link: |
Added Slovenian holidays