Added the syrian holidays

[amralsaleeh]

No description provided.

[Nielsvanpach]

Thanks! Can you rebase from main, so I can run the tests here?

[amralsaleeh]

Thanks @Nielsvanpach
Everything should be fine now and up-to-date

[Nielsvanpach]

Aren't there any official Islamic holidays in Syria?

[amralsaleeh]

Aren't there any official Islamic holidays in Syria?

Well.. sure there are Islamic holidays, but these dates are not known exactly and change every year, because it depends on the moon's movement and based on the decision of the Jurisprudential Council of the Syrian government

[Nielsvanpach]

I merged a PR for Syria, but this one seems more advanced. Would you care to fix the merge conflicts?

[Nielsvanpach]

No need to test them all. Could you pick a few and verify if the generated results in the snapshots are correct?

[amralsaleeh]

I merged a PR for Syria, but this one seems more advanced. Would you care to fix the merge conflicts?

the merged PR is for 2024 only!
It can not be true for other years!

[Nielsvanpach]

Can you take a look at the failing tests & phpstan?

Edit: you can run composer analyse locally for phpstan

[amralsaleeh]

Everything is done and working nicely. Could you please add Syria to the ignoreError section inside the phpstan.baseline file, like this:

                -
                        message: "#^Ternary operator condition is always true\\.$#"
                        count: 3
                        path: src/Countries/Turkey.php

                -

Thanks

[amralsaleeh]

👀

[spatie-bot]

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.