Adding German holidays

[arnebr]

This uses the nation-wide holidays for Germany from https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland

Regional state holidays are not part implemented in the library. Maybe @freekmurze as future plan?

[benjibee]

I was just about to open this PR! I also asked on Twitter about adding regional public holidays. Looking at the code it would be quite a big change to specify the region alongside the country.

[arnebr]

For easy implementing we could use something like de-sh but that's not "normed".
For Austria it would be the same. We could look at libraries like: https://github.com/umulmrum/holiday

[arnebr]

Notes on German Holidays

• Easter Sunday/Ostersonntag and Whit Sunday/Pfingstsonntag are not public holidays in most states.
• Every Sunday is a public holiday in Hesse.
• Assumption/Mariä Himmelfahrt is a public holiday in about 1700 of about 2000 communities in Bavaria. This is
  implemented as a partial holiday, so you might want to add your logic that filters this date.
• In Bavaria schools are closed on Assumption Day and on Repentance and Prayer Day. There is no special handling of
  this "behavior".
• Corpus Christi/Fronleichnam is a public holiday in some communities in Saxony and Thuringia.
• Regional holidays with traditionally (but not publicly) limited opening hours are not considered yet (e.g. carnival
  days).
• Some ports at the German Ocean celebrate some holidays as "High Holidays". It is generally not allowed to work on
  these days, and work time ends at 12 o'clock the day before. This is not considered yet.
• Also there are some quiet days that are not public holidays in various states. This is also not considered yet.
• New states of Germany are treated as if they had always been part of the Federal Republic of Germany. For years
  before 1990 holidays are therefore not correct.

source: https://github.com/umulmrum/holiday

[Nielsvanpach]

Regional state holidays are not part implemented in the library. Maybe freekmurze as future plan?

We are open to support this, feel free to open a PR.
Maybe the Country class can be extended with a region property, which could be used in allHolidays() ?

As this is also discussed on the Indian PR, I've added it as feature request: #14 to have a single discussion on it.

[Nielsvanpach]

I've added documentation on how I think we should manage regions or states:
https://github.com/spatie/holidays?tab=readme-ov-file#contributing-a-new-country

Could you get this PR up to date?

[arnebr]

Will do 😊

[arnebr]

@Nielsvanpach I think #37 superseeds this PR, since it's implemented all states 😊

[marlonbasten]

@arnebr As my PR won't get merged, there's still a need for German state holidays. 😕 Feel free to add this to your PR! I don't think that this package has a good implementation of it as of now, but we have to work with what we've got I guess. The package mentioned a few comments above has a good implementation with states and holiday types.

[arnebr]

Maybe @marlonbasten you could do a review of the holidays :) I implemented all of them now.
@Nielsvanpach hope that´s the way you would like to see it.

[Nielsvanpach]

PR looks good, thanks!

[Nielsvanpach]

Have you actually checked the results in the snapshots? Otherwise having only 1 region test is fine.

[arnebr]

yes thats why i found the error in the SN,BB, BE state :)

[Nielsvanpach]

Great, thanks for this!

[Nielsvanpach]

PR looks great, thanks for your work! 👍