Add Uzbekistan Holidays #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great Shoxrux 👍 |
src/Countries/Uzbekistan.php
Outdated
| ->setTimezone('Asia/Tashkent'); | ||
|
|
||
| return [ | ||
| //'Ramazon Hayiti' (Eid al-Fitr) and 'Qurbon Hayiti' (Eid al-Adha) will be added after the implementation of Islamic holidays |
There was a problem hiding this comment.
Thanks for your work! I'm keeping this PR open until we have a solution for the Islamic holidays.
There was a problem hiding this comment.
updated islamic holidays: from 1991 (after independence) to 2037 it's obtained constantly. As @thecaliskan described, Islamic holidays predicted and actual dates may change until the last moment.
There was a problem hiding this comment.
@shoxrux1996 The site you referenced (timeanddate.com) shows most dates for previous years incorrectly, using the wrong formula. Can you check from the second source?
Merged
...tries/UzbekistanTest/it_can_calculate_uzbekistan_holidays_with_data_set___2000____2000_.snap
Show resolved
Hide resolved
shoxrux1996
force-pushed
the
main
branch
2 times, most recently
from
0a333d6 to
7f2c00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference:
Public Holidays in Uzbekistan