Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Enabling Brazil Holidays #82

Closed
wants to merge 1 commit into from
Closed

[Fix] Enabling Brazil Holidays #82

wants to merge 1 commit into from

Conversation

devajmeireles
Copy link
Contributor

No description provided.

@devajmeireles devajmeireles mentioned this pull request Jan 18, 2024
Merged
@devajmeireles
Copy link
Contributor Author

@Nielsvanpach,

There is something very strange. Locally all tests pass, and CI fails.

Locally I've tested with all PHP versions:

8.1:
CleanShot 2024-01-18 at 11 16 17

8.2:
CleanShot 2024-01-18 at 11 16 34

8.3:
CleanShot 2024-01-18 at 11 16 49

@devajmeireles
Copy link
Contributor Author

I'm wondering if we don't need --update-snapshots on CI? 🤔

@Nielsvanpach
Copy link
Member

Not really. The results in the snapshot file should be verified before merging & remain unchanged after merging.

@Nielsvanpach
Copy link
Member

Thanks. We fixed this in the meantime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devajmeireles @Nielsvanpach