Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Portuguese Holidays #9

Merged
merged 8 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions src/Countries/Portugal.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<?php

namespace Spatie\Holidays\Countries;

use Carbon\CarbonImmutable;

class Portugal extends Country
{
public function countryCode(): string
{
return 'pt';
}

/** @return array<string, CarbonImmutable> */
protected function allHolidays(int $year): array
{
return array_merge([
'Dia de Ano Novo' => '01-01',
'Dia da Liberdade' => '04-25',
'Dia do Trabalhador' => '05-01',
'Dia de Portugal' => '06-10',
'Assunção da Nossa Senhora' => '08-15',
'Implantação da República' => '10-05',
'Dia de Todos os Santos' => '11-01',
'Restauração da Independência' => '12-01',
'Imaculada Conceição' => '12-08',
'Natal' => '12-25'
], $this->variableHolidays($year));
}

/** @return array<string, CarbonImmutable> */
protected function variableHolidays(int $year): array
{
$easter = CarbonImmutable::createFromTimestamp(easter_date($year))
->setTimezone('Europe/Lisbon');

return [
'Páscoa' => $easter,
'Carnaval' => $easter->subDays(47),
'Sexta-feira Santa' => $easter->subDays(2),
'Corpo de Deus' => $easter->addDays(60),
];
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
[
{
"name": "Dia de Ano Novo",
"date": "2024-01-01"
},
{
"name": "Carnaval",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an official public holiday? It's not on the list here: https://publicholidays.pt/2024-dates/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a tricky one, actually. It is not an official mandatory holiday (hence not appearing on the list) but it is a facultative holiday so it appears on most work contracts and the government validates it every year as a holiday for civil servants. In practical terms it is a holiday since nobody works and everything is closed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately like you said it’s not oficial, many companies ignore it.
It should be omitted from this list, in my opinion.
Good job with the PR 💪

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I'll remove it then.

"date": "2024-02-13"
},
{
"name": "Sexta-feira Santa",
"date": "2024-03-29"
},
{
"name": "P\u00e1scoa",
"date": "2024-03-31"
},
{
"name": "Dia da Liberdade",
"date": "2024-04-25"
},
{
"name": "Dia do Trabalhador",
"date": "2024-05-01"
},
{
"name": "Corpo de Deus",
"date": "2024-05-30"
},
{
"name": "Dia do Portugal",
"date": "2024-06-10"
},
{
"name": "Assun\u00e7\u00e3o da Nossa Senhora",
"date": "2024-08-15"
},
{
"name": "Implanta\u00e7\u00e3o da Rep\u00fablica",
"date": "2024-10-05"
},
{
"name": "Dia de Todos os Santos",
"date": "2024-11-01"
},
{
"name": "Restaura\u00e7\u00e3o da Independ\u00eancia",
"date": "2024-12-01"
},
{
"name": "Imaculada Concei\u00e7\u00e3o",
"date": "2024-12-08"
},
{
"name": "Natal",
"date": "2024-12-25"
}
]
19 changes: 19 additions & 0 deletions tests/Countries/PortugalTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

namespace Spatie\Holidays\Tests\Countries;

use Carbon\CarbonImmutable;
use Spatie\Holidays\Holidays;

it('can calculate portuguese holidays', function () {
CarbonImmutable::setTestNowAndTimezone('2024-01-01');

$holidays = Holidays::for(country: 'pt')->get();

expect($holidays)
->toBeArray()
->not()->toBeEmpty();

expect(formatDates($holidays))->toMatchSnapshot();

});