Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Algerian holidays #90

Closed
wants to merge 5 commits into from
Closed

Add Algerian holidays #90

wants to merge 5 commits into from

Conversation

celyes
Copy link

@celyes celyes commented Jan 18, 2024

Added official holidays for Algeria.

@medilies medilies mentioned this pull request Jan 20, 2024
@wessama wessama mentioned this pull request Jan 21, 2024
composer.json Outdated
"nesbot/carbon": "^2.72.1",
"ext-calendar": "*"
"ext-calendar": "*",
"geniusts/hijri-dates": "^1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protected function fixedHolidays(int $year): array
{
return [
'New Year\'s Day' => CarbonImmutable::createFromDate($year, 1, 1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the format like in other classes?
Look at Belgium.php for example

@Nielsvanpach
Copy link
Member

Thanks for your efforts, but as stated before we're not using that package.
Feel free to reopen if you're still planning to update this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants