only use needed properties

spatie · Jan 7, 2024 · d4aa770 · d4aa770
1 parent d6313ed
commit d4aa770
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -5,13 +5,6 @@
       <directory>tests</directory>
     </testsuite>
   </testsuites>
-  <coverage>
-    <report>
-      <html outputDirectory="build/coverage"/>
-      <text outputFile="build/coverage.txt"/>
-      <clover outputFile="build/logs/clover.xml"/>
-    </report>
-  </coverage>
   <logging>
     <junit outputFile="build/report.junit.xml"/>
   </logging>

diff --git a/src/ResultStores/StoredCheckResults/StoredCheckResults.php b/src/ResultStores/StoredCheckResults/StoredCheckResults.php
@@ -19,7 +19,14 @@ public static function fromJson(string $json): StoredCheckResults
         $properties = json_decode($json, true);
 
         $checkResults = collect($properties['checkResults'])
-            ->map(fn (array $lineProperties) => new StoredCheckResult(...$lineProperties))
+            ->map(fn (array $lineProperties) => new StoredCheckResult(
+                $lineProperties['name'],
+                $lineProperties['label'] ?? '',
+                $lineProperties['notificationMessage'] ?? '',
+                $lineProperties['shortSummary'] ?? '',
+                $lineProperties['status'] ?? '',
+                $lineProperties['meta'] ?? [],
+            ))
             ->unique('name')
             ->sortBy(fn (StoredCheckResult $result) => strtolower($result->label));