Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PR introduced a breaking change #27

Closed
okaufmann opened this issue Jan 17, 2025 · 1 comment
Closed

[Bug]: PR introduced a breaking change #27

okaufmann opened this issue Jan 17, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@okaufmann
Copy link

What happened?

Since version 1.2.2, my pipeline has been failing due to changes introduced in this pull request.

Specifically, the direct usage of the MJML binary now requires specifying the MJML_PATH environment variable, as outlined in the README. This breaking change makes the package incompatible without additional configuration, which I believe should not have been released as a patch update.

Additionally, I am encountering issues with Node.js throwing deprecation warnings related to the punycode package. This seems to disrupt MJML generation, as the error output affects the pipeline. However, I am not certain whether this is directly related to this package or specific to my project setup.

How to reproduce the bug

Run a GitHub Action that uses this package without specifying the MJML_PATH environment variable to help the package find the MJML binary.

Package Version

1.2.2

PHP Version

8.4.1

Which operating systems does with happen with?

macOS, Linux

Notes

No response

@riasvdv
Copy link
Member

riasvdv commented Jan 18, 2025

I've reverted the changes until we can find a better solution 👍 v1.2.3 should work as before

@riasvdv riasvdv closed this as completed Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants