Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate using a file with the cli when generating locally #26

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Generate using a file with the cli when generating locally #26

merged 9 commits into from
Jan 17, 2025

Conversation

riasvdv
Copy link
Member

@riasvdv riasvdv commented Jan 3, 2025 •
edited
Loading

This generates MJML using a temporary file, which doesn't limit the size of the MJML

@riasvdv riasvdv mentioned this pull request Jan 3, 2025
Closed
@riasvdv riasvdv requested a review from freekmurze January 16, 2025 14:54
@riasvdv riasvdv marked this pull request as ready for review January 16, 2025 14:54
@freekmurze
Copy link
Member

Looks good, thanks! 👍

@freekmurze freekmurze merged commit 70329ca into main Jan 17, 2025
10 checks passed
@okaufmann okaufmann mentioned this pull request Jan 17, 2025
Closed
riasvdv added a commit that referenced this pull request Jan 18, 2025
@riasvdv
Revert "Merge pull request #26 from spatie/feature/generate-using-cli"
a6318f0 
This reverts commit 70329ca, reversing
changes made to e31e7be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevebauman stevebauman stevebauman left review comments

@freekmurze freekmurze Awaiting requested review from freekmurze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riasvdv @freekmurze @stevebauman