Improve InvalidDate exception

spatie · Nov 28, 2018 · 3524665 · 3524665
1 parent e5823b0
commit 3524665
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Exceptions/InvalidDate.php b/src/Exceptions/InvalidDate.php
@@ -6,6 +6,11 @@
 
 class InvalidDate extends InvalidArgumentException
 {
+    public static function cannotBeNull(string $parameter): InvalidDate
+    {
+        return new static("{$parameter} cannot be null");
+    }
+
     public static function forFormat(string $date, ?string $format): InvalidDate
     {
         $message = "Could not construct a date from `{$date}`";

diff --git a/src/Period.php b/src/Period.php
@@ -36,6 +36,14 @@ public function __construct(DateTimeImmutable $start, DateTimeImmutable $end)
      */
     public static function make($start, $end, string $format = null): Period
     {
+        if ($start === null) {
+            throw InvalidDate::cannotBeNull('Start date');
+        }
+
+        if ($end === null) {
+            throw InvalidDate::cannotBeNull('Endß date');
+        }
+
         return new static(
             self::resolveDate($start, $format),
             self::resolveDate($end, $format)