-
-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dont use periods when generating a random name for the temporary dire…
…ctory
- Loading branch information
1 parent
c2e479a
commit 58e80a8
Showing
2 changed files
with
5 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58e80a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my PR I wasn't sure about
.
's being an issue and I ended up only removing spaces 😒Just curious, was
microtime()
originally used instead of generating a random string (or similar mechanism) in order to connect the directory to a specific time? I've seen it used in this way before but I'm not sure if that's following a convention?58e80a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcusmoore
microtime()
was indeed used as an alternative to generating a random string. This way the directories would be (sort of) time-stamped and there wouldn't be any chance of colliding directory names.58e80a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexVanderbist Thanks for the insight!