Store talk locale #194
Merged
Store talk locale #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaze
force-pushed
the
spaze/talk-set-locale
branch
from
78db09b
to
721ac08
Compare
spaze
added a commit
that referenced
this pull request
Aug 14, 2023
Merged
spaze
added a commit
that referenced
this pull request
Aug 14, 2023
This improves how talks in the other language are displayed. Up until now, you could have a talk in English on a `.cz` site and vice versa which I think caused some troubles for search engines and people alike. So now when the talk is in English, you'll have a `.com` link in the list of talks together with a flag icon and a language name. Also, HTTP redirects will take you where you're supposed to be, English talks on `.com` site etc., when you're not. Also, if there's an other locale talk, and it's correctly paired with the original locale talk using `key_translation_group`, you'll have a link in the header directly to the talk in the other locale. Follow-up to #194 #192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
blog_post_localestable and columns to more generallocales#192Follow-ups:
LocaleLinkGenerator#197