Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 227 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 227 commits into from

Conversation

github-classroom[bot]
Copy link
Contributor

@github-classroom github-classroom bot commented Apr 23, 2024

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

  • Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
  • Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
  • If you turned on autograding, then click the Checks tab to see the results.
  • This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
    For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @xamelllion @Sibiri4ok @Dabzelos

github-classroom bot and others added 30 commits April 23, 2024 18:40
Feature: update build.gradle.kts and add build-ci
…ith-csv

feat: add write/read CSV and  README
…ph-types

Feature/architecture/graph types
1. New package name for read/write methods
2. Method for finding cycles in undirected graphs
3. Pickable vertices in ui
4. Typo
feat: finding cycle in undirected graph
1. Add weight property to Edge
2. Change default weight type from Int -> Long
3. New graph example file
…ding

feat: implement Djkstra algorithm and visualize it
1. Update read from csv
2. Update toAdjList
3. Status messages for findPath algorithm
@toadharvard
Copy link

Обсудили лично.

Что обнаружили:

  • Алгоритм Прима считается не для всех компонент связности.
  • Не все ошибки подсвечиваются пользователю (например, некорректные входные данные в формах)
  • Можно вызвать краш, если использовать некорректные файлы для загрузки из JSON
  • Окошко можно в ноль заресайзить
  • Иногда игнорируется code-style и commit-style
  • Иногда бизнес-логика сцеплена с IO и UI
  • Есть возможности для SQL-инъекции
  • Очень долгое сохранение в Neo4j
  • Не всегда FIlePicker используется, где его хотелось бы видеть

Но несмотря на это все, алгоритмы запускаются (даже в отдельных корутинах (!)), вершины корректно подсвечиваются и работает основная функциональность приложения. Вы большие молодцы!

А еще мемы смешные в пуллреквестах 🔥

xamelllion and others added 22 commits May 31, 2024 01:47
…-reload

fix: restore offset after reload && animate scale
…UberJar

feat: add gradle target to bundle application to jar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants