LogGOPSim -V and Drawviz - Integer overflow fix #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using LogGOPSim and creating a viz file with the -V flag or reading from this file using DrawViz an integer overflow might occur with large start and end times. (Unchecked cast from
uint64_ttoint).This PR should address this issue by providing a tested and working fix.
Additionally I made some minor adaptions to the drawviz Makefile to get it building on my system.
(Changed
-lboost_regex-mtto-lboost_regex)I am not sure if this is a system-specific change for me only, if this is the case, I can drop this commit, however for completeness sake I pushed it here as well for the time being.