Improve SDFG work-depth analysis and add SDFG simulated operational intensity analysis #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons can be passed
This reverts commit eb5a6f4.
phschaad
requested changes
Jan 16, 2024
| from dace.data import Array | ||
| import sympy as sp | ||
| from collections import deque | ||
| from scipy.optimize import curve_fit |
There was a problem hiding this comment.
We should wrap this in case the package is not installed. Scipy is not a dependency of DaCe, and is only used for something optional here, so we should check if it's present and if not print a warning that states that this analysis requires scipy to work.
| from collections import deque | ||
| from scipy.optimize import curve_fit | ||
| import numpy as np | ||
| import matplotlib.pyplot as plt |
There was a problem hiding this comment.
Same with matplotlib and the plotting of analysis results.
| try: | ||
| update_mapping(mapping, e) | ||
| except: | ||
| print('\nWARNING: Strange assignment detected on InterstateEdge (e.g. bitwise operators).' |
There was a problem hiding this comment.
Suggested change
| print('\nWARNING: Strange assignment detected on InterstateEdge (e.g. bitwise operators).' | |
| print('\nWARNING: Uncommon assignment detected on InterstateEdge (e.g. bitwise operators).' |
|
PR is now tracked in #1607. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ntensity analysis (#1607) This PR is here to merge the reviewed PR #1495, which has remained inactive for a long time with minor comments open. The comments have been addressed here and merge conflicts have been resolved. --------- Co-authored-by: Cliff Hodel <[email protected]> Co-authored-by: Cliff Hodel <[email protected]> Co-authored-by: Cliff Hodel <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
…ntensity analysis (#1607) This PR is here to merge the reviewed PR #1495, which has remained inactive for a long time with minor comments open. The comments have been addressed here and merge conflicts have been resolved. --------- Co-authored-by: Cliff Hodel <[email protected]> Co-authored-by: Cliff Hodel <[email protected]> Co-authored-by: Cliff Hodel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves SDFG performance evaluation by
These analyses can also be used from the DaCe VS Code extension as implemented by these two other PRs: