Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added halide implementations for subset of npbench #8

Closed
wants to merge 2 commits into from

Conversation

lukastruemper
Copy link
Contributor

No description provided.

@lukastruemper lukastruemper requested a review from alexnick83 May 3, 2022 10:39
@lukastruemper
Copy link
Contributor Author

lukastruemper commented May 3, 2022

Not sure about this PR. Maybe nice but maybe not important now to include? Maybe find a better mechanism to run those benchmarks with the npbench infrastructure

@tbennun good ideas?

Copy link
Contributor

@alexnick83 alexnick83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check Halide's Python bindings and see if we can integrate Halide that way with the rest of the benchmark. However, we can merge this for now. Can you please write concise documentation on how to run these benchmarks? Are the results directly comparable to those from the Python frameworks? Also, do we need these parrot images? I would prefer that we avoid adding large files to the repo.

@lukastruemper lukastruemper force-pushed the users/lukas/halide-npbench branch 2 times, most recently from f100fb8 to 75fa87c Compare May 12, 2022 08:52
@lukastruemper lukastruemper marked this pull request as draft May 12, 2022 09:15
@lukastruemper lukastruemper force-pushed the users/lukas/halide-npbench branch from 6d15103 to 0c462e6 Compare May 12, 2022 13:53
@lukastruemper lukastruemper force-pushed the users/lukas/halide-npbench branch from 0c462e6 to c070ebc Compare May 13, 2022 08:55
@lukastruemper
Copy link
Contributor Author

Implemented the python bindings: #12

@lukastruemper lukastruemper deleted the users/lukas/halide-npbench branch June 24, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants