Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scf.for syntax #30

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Update scf.for syntax #30

merged 2 commits into from
Nov 27, 2023

Conversation

amanda849
Copy link
Contributor

Updating the syntax for scf.for to match the specs in the documentation.

@tbennun
Copy link
Contributor

tbennun commented Nov 22, 2023

Thank you for the PR, is it ready for review?

@amanda849
Copy link
Contributor Author

Yes, it's ready

tbennun
tbennun approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tbennun tbennun merged commit 9d0d8f8 into spcl:master Nov 27, 2023
1 check passed
@amanda849 amanda849 deleted the update_scf_for_syntax branch September 17, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanda849 @tbennun