Add linalg.transpose #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
requested changes
Oct 1, 2024
added 3 commits
October 1, 2024 08:32
tbennun
reviewed
Oct 13, 2024
There was a problem hiding this comment.
@amanda849 Are the latest changes to the test necessary? The space in the syntax definition should allow code to be written with (ins () and without whitespace (ins().
Merged
Parsing works regardless of whitespace, but the dump generated for the op syntax field includes the whitespace. For the roundtrip check to pass, the space is needed. |
|
Right, that makes perfect sense! |
tbennun
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds and tests the linalg
transposeop