Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve #25] Merge changes from #25 into libfabric-sarus branch #29

Open
wants to merge 6 commits into
base: libfabric-sarus
Choose a base branch
from

Conversation

mattnappo
Copy link
Collaborator

@mattnappo mattnappo commented Apr 4, 2023

This PR merges the work started in #25 into the libfabric-sarus branch.

Compile error fixes:
Much of the code that was split into two implementations based on the USE_LIBFABRIC and USE_CRAY_GNI flags were causing errors that did not happen in the libfabric branch. This PR fixes those errors and allows this branch to be compiled.

Core changes:

@mattnappo mattnappo changed the title Fixed 'no declaration matches' and other compiler errors [Resolve #25] Merge changes from #25 into libfabric-sarus branch Apr 5, 2023
@mcopik
Copy link
Contributor

mcopik commented May 16, 2023

@mattnappo The PR looks pretty good! I have one question only - I want to make a release of rFaaS with ibverbs only and add the container configuration there already. The work with lifabric would go into the next release.

Do you think you could reopen #25 with changes to container configuration based on master, and without lifabric and Sarus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants