updated support for benchmark language versions #198

octonawish-akcodes · 2024-03-27T21:24:25Z

Need reviews cc @mcopik

Related issue #196

Summary by CodeRabbit

New Features
- Added /alive route to Node.js and Python servers that returns a status response.
- Introduced a new url property to the Function class for better URL handling.
Dependency Updates
- Updated sharp dependency for Node.js thumbnailer module.
- Added pillow package and specific versions for multiple benchmarks.
- Introduced igraph package for scientific benchmarks.
- Updated Python and Node.js versions in configuration files.
Enhancements
- Enhanced Azure function deployment with updated version settings.
- Improved server setup in the local environment with a new waiting mechanism.
Documentation
- Updated benchmark documentation for GCP compatibility issues with specific Python versions.
Bug Fixes
- Refined function names and handlers in Python server for clarity.

config/systems.json

mcopik · 2024-03-30T02:49:00Z

config/systems.json

@@ -170,7 +170,6 @@
      },
      "nodejs": {
        "base_images": {
-          "10": "gcr.io/google-appengine/nodejs",
          "12": "gcr.io/google-appengine/nodejs",


What's the situation on Azure/GCP?

I checked the python, nodejs version supports on gcp, azure, openwhisk official documentation most of them supports python versions 3.8 and above and for nodejs 18 and above.

mcopik · 2024-04-11T11:43:49Z

@octonawish-akcodes Hi, any update on my comments?

Signed-off-by: Abhishek Kumar <[email protected]>

octonawish-akcodes · 2024-04-12T08:26:17Z

@mcopik I updated the PR with the changes, have a look and I would be happy to answer any further queries :)

mcopik · 2024-04-16T08:59:40Z

@octonawish-akcodes Thank you! On which platforms and languages did you verify it works? We need to run the benchmarks as some of them might break, e.g., due to a different language version required. For example, a common issue is the Pillow library for the thumbnail benchmark :)

We can use SeBS regression to simplify the process, e.g., ./sebs.py benchmark regression test --config config/example.json --language nodejs --language-version 18 --deployment gcp

octonawish-akcodes · 2024-04-16T09:46:33Z

Hi, I verfied them against the official documentation of the cloud platforms. Supported links are as follows:
For Azure:
Python (https://learn.microsoft.com/en-us/azure/azure-functions/functions-reference-python?tabs=asgi%2Capplication-level&pivots=python-mode-decorators#python-version)

Nodejs( https://azure.microsoft.com/en-in/updates/generally-available-azure-functions-support-for-nodejs-18/ )

For GCP:

Python (https://devguide.python.org/versions/#supported-versions)
Nodejs (https://github.com/googleapis/google-cloud-node)

For openwhisk

Python and Nodejs (https://openwhisk.apache.org/downloads.html)

mcopik · 2024-04-16T09:48:06Z

Yes, that is a very important first step. However, we need also to execute benchmarks against specified version to check they work in practice.

octonawish-akcodes · 2024-04-16T09:49:59Z

I can only try on the Azure platform since I don't have accounts on other platforms

mcopik · 2024-04-16T19:30:47Z

@octonawish-akcodes I think we can also add Python 3.10 on AWS Lambda.

octonawish-akcodes · 2024-04-17T03:59:07Z

@octonawish-akcodes I think we can also add Python 3.10 on AWS Lambda.

I just checked it https://aws.amazon.com/about-aws/whats-new/2023/04/aws-lambda-python-3-10/ I'll add it

Signed-off-by: Abhishek Kumar <[email protected]>

prajinkhadka · 2024-04-17T15:42:48Z

I was just running benchmarks for python3.10 on AWS, these are the results of the regression test. Some benchmark breaks are due to language version requirements.

Succesfully executed 5 out of 10 functions
- 311.compression
- 504.dna-visualisation
- 110.dynamic-html
- 120.uploader
- 220.video-processing
Failures when executing 5 out of 10 functions
- 411.image-recognition
- 210.thumbnailer
- 503.graph-bfs
- 502.graph-mst
- 501.graph-pagerank

octonawish-akcodes · 2024-04-17T16:07:32Z

Can you share the failure, curious to see the traceback @prajinkhadka

mcopik · 2024-04-17T21:37:38Z

@prajinkhadka 411 is expected, we documented it :-) It just won't work without Docker images due to code size. But please share the error, I'm curious if it's possibly something else.

210 is likely a fixed Pillow version, and 50* is likely a fixed igraph version.

prajinkhadka · 2024-04-17T23:37:36Z

Most probably it is the issue with the versions as mentioned by Marcin.

Regarding the 411 the issue should be with the code size limitation. I will check and update here if it's something else.

octonawish-akcodes · 2024-04-18T02:56:46Z

It will be better if u could post the whole traceback here.

prajinkhadka · 2024-04-18T04:57:25Z

@octonawish-akcodes Here you go. Need to install the correct version of Pillow and igraph for Python3.10

For 50* , traceback from Lambda:

{
  "errorMessage": "No module named 'igraph'",
  "errorType": "ModuleNotFoundError",
  "requestId": "e3d32a4b-1ee6-435f-8526-89cfe0fcc9f0",
  "stackTrace": [
    "  File \"/var/task/handler.py\", line 20, in handler\n    from function import function\n",
    "  File \"/var/task/function/function.py\", line 2, in <module>\n    import igraph\n"
  ]
}

For 210:

{
  "errorMessage": "No module named 'PIL'",
  "errorType": "ModuleNotFoundError",
  "requestId": "1b573fce-2abc-478f-8eae-9b4635168334",
  "stackTrace": [
	"  File \"/var/task/handler.py\", line 20, in handler\n	from function import function\n",
	"  File \"/var/task/function/function.py\", line 7, in <module>\n	from PIL import Image\n"
  ]
}

mcopik · 2024-04-19T10:47:03Z

@prajinkhadka Can you please post the correct versions here - or even better if both you and @octonawish-akcodes can push to the same branch.

prajinkhadka · 2024-04-20T02:46:04Z

@mcopik Yes, I will be doing it.

…bnailer

….pagerank

…-mst

…h-bfs

octonawish-akcodes · 2024-05-31T12:59:52Z

On Azure platform when i try to experiment benchmarks with python version 3.8, I am getting this error and even after exporting the certification using this command export PYCURL_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt it still gave me the same error, any comment @mcopik

-------------

sebs.regression.AzureTestSequencePython.test_azure_210.thumbnailer: fail
sebs.regression.AzureTestSequencePython.test_azure_210.thumbnailer: Traceback (most recent call last):
  File "/home/abhi_ubuntu/sebs/serverless-benchmarks/sebs/regression.py", line 86, in test
    ret = trigger.sync_invoke(input_config)
  File "/home/abhi_ubuntu/sebs/serverless-benchmarks/sebs/azure/triggers.py", line 35, in sync_invoke
    return self._http_invoke(payload, self.url)
  File "/home/abhi_ubuntu/sebs/serverless-benchmarks/sebs/faas/function.py", line 206, in _http_invoke
    c.perform()
pycurl.error: (77, 'error setting certificate verify locations:\n  CAfile: /etc/pki/tls/certs/ca-bundle.crt\n  CApath: none')

octonawish-akcodes · 2024-05-31T13:02:34Z

Also on running the benchmarks against python version 3.10, all benchmarks are failed to execute.

-------------

sebs.regression.AzureTestSequencePython.test_azure_210.thumbnailer: fail
sebs.regression.AzureTestSequencePython.test_azure_210.thumbnailer: Traceback (most recent call last):
  File "/home/abhi_ubuntu/sebs/serverless-benchmarks/sebs/regression.py", line 66, in test
    func = deployment_client.get_function(
  File "/home/abhi_ubuntu/sebs/serverless-benchmarks/sebs/faas/system.py", line 147, in get_function
    raise Exception(
Exception: Unsupported python version 3.10 in azure!


-------------

octonawish-akcodes · 2024-06-03T04:32:05Z

On Azure with python version 3.8 test results:

cc @mcopik

coderabbitai

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

docs/benchmarks.md (1)
29-29: LGTM! Fix minor language inconsistency.

The added warning about the image-recognition benchmark not working on GCP with Python 3.8+ due to excessive code size is informative and necessary.

However, the phrase "In future" should be corrected to "In the future" to maintain consistency in language.
- In future, we might support Docker-based deployment on AWS that are not affected by code size limitations.
+ In the future, we might support Docker-based deployment on AWS that are not affected by code size limitations.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f553d8e and 587c1a1.

Files selected for processing (9)

benchmarks/200.multimedia/210.thumbnailer/nodejs/package.json.18 (1 hunks)
benchmarks/200.multimedia/210.thumbnailer/nodejs/package.json.20 (1 hunks)
benchmarks/400.inference/411.image-recognition/python/requirements.txt.3.10 (1 hunks)
benchmarks/400.inference/411.image-recognition/python/requirements.txt.3.11 (1 hunks)
config/systems.json (10 hunks)
docs/benchmarks.md (1 hunks)
sebs/azure/azure.py (7 hunks)
sebs/azure/cli.py (1 hunks)
sebs/regression.py (2 hunks)

Files skipped from review due to trivial changes (4)

benchmarks/200.multimedia/210.thumbnailer/nodejs/package.json.18
benchmarks/200.multimedia/210.thumbnailer/nodejs/package.json.20
benchmarks/400.inference/411.image-recognition/python/requirements.txt.3.11
sebs/azure/cli.py

Files skipped from review as they are similar to previous changes (2)

benchmarks/400.inference/411.image-recognition/python/requirements.txt.3.10
sebs/regression.py

Additional context used

LanguageTool

docs/benchmarks.md

[locale-violation] ~26-~26: The phrase ‘In future’ is British English. Did you mean: “In the future”?
Context: ...ue to 30 second timeout of API gateway. In future, we might support Docker-based deployme...

(IN_FUTURE)

Markdownlint

docs/benchmarks.md

27-27: null
Blank line inside blockquote

(MD028, no-blanks-blockquote)

Ruff

sebs/azure/azure.py

209-209: Use context handler for opening files

(SIM115)

Additional comments not posted (9)

config/systems.json (6)

20-21: LGTM!

The addition of Python 3.8 and 3.9 base images for local experiments looks good.

37-38: LGTM!

The addition of Node.js 18 and 20 base images for local experiments looks good.

58-59: LGTM!

The addition of Python 3.11 and 3.10 base images for AWS looks good.

108-109: LGTM!

The addition of Python 3.9 and 3.10 base images for Azure looks good.

127-129: LGTM!

The addition of Node.js 16, 18, and 20 base images for Azure looks good.

200-202: LGTM!

The addition of Python 3.9, 3.10, and 3.11 base images for OpenWhisk looks good.

sebs/azure/azure.py (3)

206-207: LGTM!

The update to the extension bundle version to [4.0.0, 5.0.0) looks good.

219-219: LGTM!

The addition of the container destination parameter to the publish_function looks good.

291-292: LGTM!

The modification to return the destination container path in the update_function looks good.

mcopik · 2024-07-09T20:05:17Z

Update to PR:

AWS support confirmed up to Python 3.11 and Node.js 16. For Python 3.12, we need to update Dockerfile to the new Amazon Linux ( Support AWS functions using Amazon Linux 2023 #208). For Node.js 18 and 20, we need to support AWS SDK v3 (Support AWS SDK v3 for Nodejs #207)
Azure now supports Python 3.7-3.10 with runtime 4.0, and Node.js 16-20.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 587c1a1 and 8713e9e.

Files selected for processing (6)

benchmarks/200.multimedia/210.thumbnailer/python/requirements.txt.3.12 (1 hunks)
benchmarks/500.scientific/501.graph-pagerank/python/requirements.txt.3.12 (1 hunks)
benchmarks/500.scientific/502.graph-mst/python/requirements.txt.3.12 (1 hunks)
benchmarks/500.scientific/503.graph-bfs/python/requirements.txt.3.12 (1 hunks)
config/systems.json (10 hunks)
sebs/regression.py (4 hunks)

Files skipped from review due to trivial changes (4)

benchmarks/200.multimedia/210.thumbnailer/python/requirements.txt.3.12
benchmarks/500.scientific/501.graph-pagerank/python/requirements.txt.3.12
benchmarks/500.scientific/502.graph-mst/python/requirements.txt.3.12
benchmarks/500.scientific/503.graph-bfs/python/requirements.txt.3.12

Files skipped from review as they are similar to previous changes (2)

config/systems.json
sebs/regression.py

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8713e9e and de412d4.

Files selected for processing (3)

config/systems.json (10 hunks)
dockerfiles/gcp/nodejs/Dockerfile.build (2 hunks)
dockerfiles/nodejs_installer.sh (1 hunks)

Additional comments not posted (16)

dockerfiles/nodejs_installer.sh (3)

3-5: Verify the definition of $FILE.

Ensure that the variable $FILE is defined earlier in the script or passed as an environment variable to avoid potential issues.

4-4: Confirm the necessity of sourcing nvm.sh.

Sourcing nvm.sh is required for Node Version Manager (NVM) to function correctly. Ensure that this file path is correct and that NVM is installed.

6-6: Ensure the correctness of the cd command.

Verify that the path /mnt/function exists and is the intended directory for running npm install. Additionally, consider handling potential errors if the directory does not exist.

dockerfiles/gcp/nodejs/Dockerfile.build (4)

4-4: Verify the setup of NVM.

Ensure that the environment variable NVM_DIR is correctly set and that the directory /nvm is the intended location for NVM.

7-7: Confirm the necessity of gosu and wget.

Verify that gosu and wget are necessary for the Docker build process. gosu is typically used to run commands as a different user, and wget is used for downloading files.

8-8: Ensure the NVM installation script URL is correct.

Verify that the URL https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh is correct and points to the intended version of NVM.

9-9: Check the correctness of NVM usage commands.

Ensure that the commands . ${NVM_DIR}/nvm.sh && nvm install ${VERSION} && nvm alias default ${VERSION} && nvm use default correctly set up and use the specified Node.js version.

config/systems.json (9)

20-21: Verify the correctness of Python base images for local experiments.

Ensure that the base images python:3.8-slim and python:3.9-slim are correct and compatible with the local experiments.

37-38: Verify the correctness of Node.js base images for local experiments.

Ensure that the base images node:18-slim and node:20-slim are correct and compatible with the local experiments.

58-61: Verify the correctness of Python base images for AWS.

Ensure that the base images amazon/aws-lambda-python:3.11, amazon/aws-lambda-python:3.10, amazon/aws-lambda-python:3.9, and amazon/aws-lambda-python:3.8 are correct and supported by AWS Lambda.

99-101: Verify the correctness of Python base images for Azure.

Ensure that the base images mcr.microsoft.com/azure-functions/python:3.0-python3.9, mcr.microsoft.com/azure-functions/python:4-python3.10, and mcr.microsoft.com/azure-functions/python:4-python3.11 are correct and supported by Azure Functions.

119-121: Verify the correctness of Node.js base images for Azure.

Ensure that the base images mcr.microsoft.com/azure-functions/node:4-node16, mcr.microsoft.com/azure-functions/node:4-node18, and mcr.microsoft.com/azure-functions/node:4-node20 are correct and supported by Azure Functions.

150-153: Verify the correctness of Python base images for GCP.

Ensure that the base images ubuntu:22.04 for Python versions 3.8, 3.9, 3.10, 3.11, and 3.12 are correct and supported by Google Cloud Platform.

171-176: Verify the correctness of Node.js base images for GCP.

Ensure that the base images ubuntu:18.04 for Node.js versions 10, 12, 14, 16, and ubuntu:22.04 for Node.js versions 18 and 20 are correct and supported by Google Cloud Platform.

199-201: Verify the correctness of Python base images for OpenWhisk.

Ensure that the base images openwhisk/action-python-v3.9, openwhisk/action-python-v3.10, and openwhisk/action-python-v3.11 are correct and supported by OpenWhisk.

220-221: Verify the correctness of Node.js base images for OpenWhisk.

Ensure that the base images openwhisk/action-nodejs-v18 and openwhisk/action-nodejs-v20 are correct and supported by OpenWhisk.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between de412d4 and 86920aa.

Files selected for processing (1)

config/systems.json (10 hunks)

Files skipped from review as they are similar to previous changes (1)

config/systems.json

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 86920aa and e0c2915.

Files selected for processing (7)

config/systems.json (10 hunks)
dockerfiles/local/nodejs/server.js (1 hunks)
dockerfiles/local/python/Dockerfile.build (1 hunks)
dockerfiles/local/python/server.py (1 hunks)
requirements.txt (1 hunks)
sebs/local/function.py (1 hunks)
sebs/local/local.py (2 hunks)

Files skipped from review due to trivial changes (2)

dockerfiles/local/python/Dockerfile.build
requirements.txt

Files skipped from review as they are similar to previous changes (1)

config/systems.json

Additional comments not posted (4)

dockerfiles/local/python/server.py (1)

18-18: Function renamed to process_request.

The function flush_log was renamed to process_request. Ensure that all references to this function are updated accordingly.

dockerfiles/local/nodejs/server.js (1)

12-16: LGTM! The /alive route handler is correctly implemented.

The new route handler for /alive correctly returns a JSON status.

sebs/local/function.py (1)

70-73: LGTM! The url property is correctly implemented.

The new url property correctly returns the URL of the local function.

sebs/local/local.py (1)

226-243: LGTM! The server availability check in create_function is correctly implemented.

The code correctly waits for the server to become available before proceeding.

coderabbitai · 2024-07-10T01:06:02Z

dockerfiles/local/python/server.py

+@route('/alive', method='GET')
+def alive():
+    return {
+        "result:" "ok"
+    }


Fix the syntax error in the /alive route handler.

There is a missing comma in the dictionary returned by the alive function.

- "result:" "ok" + "result": "ok"

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

@route('/alive', method='GET')

def alive():

return {

"result:" "ok"

}

@route('/alive', method='GET')

def alive():

return {

"result": "ok"

}

mcopik · 2024-07-10T12:03:42Z

@octonawish-akcodes @prajinkhadka Thank you for your help!

octonawish-akcodes mentioned this pull request Mar 27, 2024

Updating support for benchmark language versions #196

Closed

8 tasks

mcopik requested changes Mar 30, 2024

View reviewed changes

updated support for benchmark language versions

2f09f26

Signed-off-by: Abhishek Kumar <[email protected]>

octonawish-akcodes force-pushed the sebs4 branch from 940e85e to 2f09f26 Compare April 12, 2024 08:23

octonawish-akcodes requested a review from mcopik April 12, 2024 08:26

added aws lambda python3.10 support

483fd88

Signed-off-by: Abhishek Kumar <[email protected]>

prajinkhadka added 4 commits May 29, 2024 23:22

Create requirements.txt.3.10 for Python3.10 for Benchamark - 210.thum…

a4ea1a8

…bnailer

Create requirements.txt.3.10 for Python3.10 for Benchmark - 501.graph…

877be27

….pagerank

Create requirements.txt.3.10 for Python3.10 for Benchmark - 502.graph…

0dc5287

…-mst

Create requirements.txt.3.10 for Python 3.10 for Benchmark - 503.grap…

2e9daf7

…h-bfs

prajinkhadka mentioned this pull request May 29, 2024

[Fix] : Update requirements for Pillow and Igraph for Python3.10 #200

Closed

mcopik added 4 commits July 9, 2024 21:08

[benchmarks] Upgrade 411.image-recognition to Python 3.11

52097e8

[benchmarks] Support 210.thumbnailer on Node.js 16, 18 & 20

598c4ce

[docs] Update info about Python versions on Google Cloud

7c77e2c

[azure] Add documentation on the problematic upload of archive to Docker

587c1a1

coderabbitai bot reviewed Jul 9, 2024

View reviewed changes

mcopik added 3 commits July 9, 2024 22:17

[regression] Use single deployment for gcp

ea153a4

[benchmarks] Update benchmarks for Python 3.12

8ee7b80

[gcp] Update supported versions

8713e9e

coderabbitai bot reviewed Jul 9, 2024

View reviewed changes

[gcp] Update Docker images to work with Node.js 18 and 20

de412d4

coderabbitai bot reviewed Jul 9, 2024

View reviewed changes

mcopik added 3 commits July 10, 2024 01:52

[openwhisk] Update Openwhisk images

8cdff2d

[openwhisk] Revert old Python version

917e2b4

[gcp] Revert older Python version

86920aa

coderabbitai bot reviewed Jul 10, 2024

View reviewed changes

mcopik added 5 commits July 10, 2024 02:41

[local] Add GET method to control if server is alive

82b66c4

[local] Wait until container is running

131145f

[local] Adapt the build image to Python3

6d05bb2

[local] Update supported languge versions

8cb9807

[local] Extend node.js server with a GET alive method

e0c2915

mcopik approved these changes Jul 10, 2024

View reviewed changes

coderabbitai bot reviewed Jul 10, 2024

View reviewed changes

mcopik merged commit c841592 into spcl:master Jul 10, 2024

mcopik mentioned this pull request Jul 10, 2024

Python3.7 runtime not supported in AWS Lambda while creating the function #189

Closed

This was referenced Sep 9, 2024

Interface for Queues #220

Open

[#64] Queue and Storage triggers for AWS, GCP and Azure #201

Open

This was referenced Nov 3, 2024

Minor updates to PR #199 #226

Merged

Container support for AWS #205

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated support for benchmark language versions #198

updated support for benchmark language versions #198

octonawish-akcodes commented Mar 27, 2024 •

edited by coderabbitai bot

Loading

mcopik Mar 30, 2024

octonawish-akcodes Apr 12, 2024

mcopik commented Apr 11, 2024

octonawish-akcodes commented Apr 12, 2024 •

edited

Loading

mcopik commented Apr 16, 2024

octonawish-akcodes commented Apr 16, 2024

mcopik commented Apr 16, 2024

octonawish-akcodes commented Apr 16, 2024

mcopik commented Apr 16, 2024

octonawish-akcodes commented Apr 17, 2024

prajinkhadka commented Apr 17, 2024

octonawish-akcodes commented Apr 17, 2024

mcopik commented Apr 17, 2024 •

edited

Loading

prajinkhadka commented Apr 17, 2024

octonawish-akcodes commented Apr 18, 2024

prajinkhadka commented Apr 18, 2024 •

edited

Loading

mcopik commented Apr 19, 2024

prajinkhadka commented Apr 20, 2024

octonawish-akcodes commented May 31, 2024

octonawish-akcodes commented May 31, 2024

octonawish-akcodes commented Jun 3, 2024

coderabbitai bot left a comment

mcopik commented Jul 9, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot Jul 10, 2024

mcopik commented Jul 10, 2024

updated support for benchmark language versions #198

updated support for benchmark language versions #198

Conversation

octonawish-akcodes commented Mar 27, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

mcopik Mar 30, 2024

Choose a reason for hiding this comment

octonawish-akcodes Apr 12, 2024

Choose a reason for hiding this comment

mcopik commented Apr 11, 2024

octonawish-akcodes commented Apr 12, 2024 • edited Loading

mcopik commented Apr 16, 2024

octonawish-akcodes commented Apr 16, 2024

mcopik commented Apr 16, 2024

octonawish-akcodes commented Apr 16, 2024

mcopik commented Apr 16, 2024

octonawish-akcodes commented Apr 17, 2024

prajinkhadka commented Apr 17, 2024

octonawish-akcodes commented Apr 17, 2024

mcopik commented Apr 17, 2024 • edited Loading

prajinkhadka commented Apr 17, 2024

octonawish-akcodes commented Apr 18, 2024

prajinkhadka commented Apr 18, 2024 • edited Loading

mcopik commented Apr 19, 2024

prajinkhadka commented Apr 20, 2024

octonawish-akcodes commented May 31, 2024

octonawish-akcodes commented May 31, 2024

octonawish-akcodes commented Jun 3, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

mcopik commented Jul 9, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Jul 10, 2024

Choose a reason for hiding this comment

mcopik commented Jul 10, 2024

octonawish-akcodes commented Mar 27, 2024 •

edited by coderabbitai bot

Loading

octonawish-akcodes commented Apr 12, 2024 •

edited

Loading

mcopik commented Apr 17, 2024 •

edited

Loading

prajinkhadka commented Apr 18, 2024 •

edited

Loading