Fix incorrect javadoc configuration

[dwalluck]

No description provided.

[dwalluck]

This removes the incorrect <additionalparam> tag (I think you meant <additionalOptions>). This code wasn't necessary anyway since you already have -Xdoclint:none in the global configuration.

So, I just moved the property to the global configuration, but you could remove the use of the property altogether, since building on JDK < 1.8 is not even possible. In which case, we could delete the 1.8+ profile and add back the hardcoded -Xdoclint:none.

[goneall]

Agree we should get rid of the old historic check for JDK < 1.8 - perhaps we should use the doclint parameter instead. What do you think?

[dwalluck]

Agree we should get rid of the old historic check for JDK < 1.8 - perhaps we should use the doclint parameter instead. What do you think?

That's fine. The alternative is to leave it on and (eventually) fix all warnings. It doesn't look like there are that many.

[goneall]

Agree we should get rid of the old historic check for JDK < 1.8 - perhaps we should use the doclint parameter instead. What do you think?

That's fine. The alternative is to leave it on and (eventually) fix all warnings. It doesn't look like there are that many.

I've been slowly working through removing the warnings. Removing the warnings would be fine as well.

[dwalluck]

I've been slowly working through removing the warnings. Removing the warnings would be fine as well.

In that case, I suggest removing all references to doclint in the POM and just let it print the warnings for now. I will update the pull request if you agree.

[dwalluck]

@goneall OK, actually, I have added <doclint> which matches how Spdx-Java-Library is now.

[goneall]

Thanks @dwalluck