Review comments for ws-patches PR

Signed-off-by: Nicolaus Weidner <[email protected]>

setup.py

@@ -13,8 +13,8 @@ def test_suite():
     long_description = fh.read()
 
 setup(
-    name='ws-spdx-tools',
-    version='0.7.0a3.post7',
+    name='spdx-tools',
+    version='0.7.0a3',
     description='SPDX parser and tools.',
     long_description=long_description,
     long_description_content_type='text/markdown',

spdx/relationship.py

@@ -83,7 +83,10 @@ def __init__(self, relationship=None, relationship_comment=None):
         self.relationship_comment = relationship_comment
 
     def __eq__(self, other):
-        return True if self.relationship == other.relationship else False
+        return (
+                isinstance(other, Relationship)
+                and self.relationship == other.relationship
+        )
 
     @property
     def has_comment(self):

spdx/writers/json.py

@@ -14,20 +14,14 @@
 from spdx.writers.tagvalue import InvalidDocumentError
 from spdx.writers.jsonyamlxml import Writer
 from spdx.parsers.loggers import ErrorMessages
-import numpy as np
 import datetime
 
 
-# this method has been added by the WhiteSouse PS Team.
 def json_converter(obj):
-    if isinstance(obj, np.integer):
-        return int(obj)
-    elif isinstance(obj, np.floating):
-        return float(obj)
-    elif isinstance(obj, np.ndarray):
-        return obj.tolist()
-    elif isinstance(obj, datetime.datetime):
-        return obj.__str__()
+    if isinstance(obj, datetime.datetime):
+        return str(obj)
+    else:
+        raise TypeError("No implementation available to serialize objects of type " + type(obj).__name__)
 
 
 def write_document(document, out, validate=True):

spdx/writers/jsonyamlxml.py

@@ -379,10 +379,6 @@ def __init__(self, document):
 
     def create_extracted_license(self):
         extracted_license_objects = []
-        # commented by the WS PS Team
-        # extracted_licenses = self.document.extracted_licenses
-
-        # filter by unique identifier attribute in ExtractedLicense object, added by the WhiteSouse PS Team
         unique_extracted_licenses = {}
         for lic in self.document.extracted_licenses:
             if lic.identifier not in unique_extracted_licenses.keys():
@@ -545,4 +541,3 @@ def create_document(self):
             self.document_object["relationships"] = self.create_relationship_info()
 
         return self.document_object
-

spdx/writers/rdf.py

@@ -570,7 +570,7 @@ def relationships(self):
         """
         Return a list of relationship nodes
         """
-        return list(map(self.create_relationship_node, self.document.relationships))
+        return map(self.create_relationship_node, self.document.relationships)
 
 
 class CreationInfoWriter(BaseWriter):