Merge pull request #5240 from specify/issue-5154

Fix Table Aggregation Separator being set to undefined if it matches default "; "
specify · Aug 28, 2024 · f58f0d4 · f58f0d4
2 parents d58797e + 5378b96
commit f58f0d4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/specifyweb/frontend/js_src/lib/components/Formatters/spec.ts b/specifyweb/frontend/js_src/lib/components/Formatters/spec.ts
@@ -147,7 +147,7 @@ const aggregatorSpec = f.store(() =>
     ),
     separator: pipe(
       syncers.xmlAttribute('separator', 'empty', false),
-      syncers.default(localized('; '))
+      syncers.fallback(localized('; '))
     ),
     suffix: syncers.xmlAttribute('ending', 'empty', false),
     limit: pipe(

diff --git a/specifyweb/stored_queries/format.py b/specifyweb/stored_queries/format.py
@@ -263,7 +263,7 @@ def aggregate(self, query: QueryConstruct,
         formatter_name = aggregator_formatter_name
         if not self.hasFormatterDef(specify_model, aggregator_formatter_name):
             formatter_name = aggregatorNode.attrib.get('format', None)
-        separator = aggregatorNode.attrib.get('separator', ',')
+        separator = aggregatorNode.attrib.get('separator', '; ')
         order_by = aggregatorNode.attrib.get('orderfieldname', '')
         limit = aggregatorNode.attrib.get('count', '')
         limit = None if limit == '' or int(limit) == 0 else limit