feat(KeyboardShortcuts): add customizable shortcuts for common actions #5097
+1,831
−392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpatiiuk
changed the title
8 tasks
maxpatiiuk
force-pushed
the
keyboard-shortcuts
branch
from
d19d3ec
to
d3623a8
Compare
"Keyboard" is a bit too generic/ambiguous
- Replace "show nodes with children only" checkbox with a toggle button.
Reasons:
- The checkbox was the only thing below the tree viewer - occupying
an entire line of horizontal space.
- Because of how Tab and Shift+Tab keys are used in the tree viewer,
moving focus to elements below the tree viewer is not possible - you
can only move above the tree viewer. That made this checkbox
inaccessible from keyboard
- The label for this checkbox is long, adding visual noise - it's
cleaner as a small tidy button
- Don't display split view controls if split view is not enabled to
reduce visual clutter
maxpatiiuk
force-pushed
the
keyboard-shortcuts
branch
from
d3623a8
to
aa3beed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1746
Checklist
and self-explanatory (or properly documented)
Testing instructions
Keyboard Shortcutsitem to User tools - verify it looks goodKeyboard Shortcutspage that has a default value assigned, make sure that the default keyboard shortcuts we have set do not already have an action assigned to them (we don't want to overwrite default browser or OS actions, unless we really have to, or unless user would expect us to do so)