-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow catalogNumber format to be determined by CollectionObjectType #5431
Open
melton-jason
wants to merge
25
commits into
production
Choose a base branch
from
issue-5232
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+598
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ONLY affects autonumbering. QB and WB still use Collection -> catalogNumFormatName
melton-jason
changed the title
Allow CollectionObjects to be autonumbered by CollectionObjectType
Allow catalogNumber format to be determined by CollectionObjectType
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5232, #5233
See #5234
Aside from implementing #5232 and #5233, there are some other improvements in this PR!
Schema Config
fieldName=fieldname
) above the restMigrations
There were some bugs in other migrations which used the functions defined in specifyweb/specify/update_schema_config.py. These bugs have been fixed in this PR, and a migration has been written to fix these bugs for databases already affected: specify/0017_schemaconfig_fixes.py
UIFormatter picklists for Collection -> catalogNumFormatName and CollectionObjectType -> catalogNumberFormatName
CO -> catalogNumber
Field Formatters*on the DataEntry Form, they will only appear as a PickList if
uitype="combobox"
is used on the form definitionChecklist
and self-explanatory (or properly documented)
Testing instructions
Collection Object -> catalogNumber
which is different than the currentCollection -> Catalog Num Format Name
Rocks
is provided below:collectionObjectType
is on the Collection Object form