-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow COG selection for interactions #5445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify that only the prep you selected has been added to the Loan perps
- Verify that the prep you selected has been added to the Loan perps + the siblings of that CO
- Verify that only the prep you selected has been added to the Loan perps
- Verify that only the prep you selected has been added to the Loan perps
- Verify that the prep you selected has been added to the Loan perps + all the siblings
- Verify that only the prep you selected from the non conso has been added to the Loan perps + the prep from the conso COG and all its siblings
Trying to add a COG rs to a loan throws an error.
chrome_jwLga5p17d.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Verify that only the prep you selected has been added to the Loan perps
- Verify that the prep you selected has been added to the Loan perps + the siblings of that CO
- Verify that only the prep you selected has been added to the Loan perps
- Verify that only the prep you selected has been added to the Loan perps
- Verify that the prep you selected has been added to the Loan perps + all the siblings
- Verify that only the prep you selected from the non conso has been added to the Loan perps + the prep from the conso COG and all its siblings
Adding COG record sets is working now.
In all the cases the preps are being grouped together only when appropriate 👍👍👍
@CarolineDenis This PR does not follow the requirements as they were written– can you write a brief summary of what was skipped and why? Re: #5422 Not for my personal reference, but for the record |
fixes #5422
Checklist
and self-explanatory (or properly documented)
Testing instructions
For the preparation:
For all COs be sure they have preps
For testing:
CO not Conso COG child using enter cat num
CO Conso COG child using enter cat num
CO RS using choose RS
COG non conso using choose RS
COG conso using choose RS
COG mix using choose RS