Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow COG selection for interactions #5445

Merged
merged 55 commits into from
Dec 19, 2024
Merged

Allow COG selection for interactions #5445

merged 55 commits into from
Dec 19, 2024

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Dec 5, 2024

fixes #5422

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

For the preparation:
For all COs be sure they have preps

  • Create RS (RS COs with 1 conso child) with different COs, have at least one of them be a part of a consolidate COG
  • Create RS (RS COs with 0 conso child) with different COs, be sure no COs are part of a conso COG
  • Create RS (RS COGs with 1 conso COG) with different COGs, have at least one of them be a consolidate COG
  • Create RS (RS COGs with 0 conso COG) with different COGs, be sure no COGs are conso COG
  • Create a mix RS

For testing:

CO not Conso COG child using enter cat num

  • Open Loan dialog
  • Enter the cat num of a CO that is NOT a part of conso COG
  • Add a prep to the loan
  • Verify that only the prep you selected has been added to the Loan perps

CO Conso COG child using enter cat num

  • Open Loan dialog
  • Enter the cat num of a CO that is a part of conso COG
  • Add a prep to the loan
  • Verify that the prep you selected has been added to the Loan perps + the siblings of that CO

CO RS using choose RS

  • Open Loan dialog
  • Choose RS with COs
  • Add a prep to the loan
  • Verify that only the prep you selected has been added to the Loan perps

COG non conso using choose RS

  • Open Loan dialog
  • Choose RS with COGs that are not conso
  • Add a prep to the loan
  • Verify that only the prep you selected has been added to the Loan perps

COG conso using choose RS

  • Open Loan dialog
  • Choose RS with COGs that are conso
  • Add a prep to the loan
  • Verify that the prep you selected has been added to the Loan perps + all the siblings

COG mix using choose RS

  • Open Loan dialog
  • Choose RS with mix COGs
  • Add a prep to the loan from the conso COG and a prep from the other type
  • Verify that only the prep you selected from the non conso has been added to the Loan perps + the prep from the conso COG and all its siblings

@CarolineDenis CarolineDenis requested a review from a team December 16, 2024 21:47
@CarolineDenis CarolineDenis marked this pull request as ready for review December 16, 2024 21:47
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that only the prep you selected has been added to the Loan perps
  • Verify that the prep you selected has been added to the Loan perps + the siblings of that CO
  • Verify that only the prep you selected has been added to the Loan perps
  • Verify that only the prep you selected has been added to the Loan perps
  • Verify that the prep you selected has been added to the Loan perps + all the siblings
  • Verify that only the prep you selected from the non conso has been added to the Loan perps + the prep from the conso COG and all its siblings

Trying to add a COG rs to a loan throws an error.

chrome_jwLga5p17d.mp4

Specify 7 Crash Report - 2024-12-17T16_07_07.052Z.txt

@CarolineDenis CarolineDenis requested review from emenslin and a team December 18, 2024 16:05
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Verify that only the prep you selected has been added to the Loan perps
  • Verify that the prep you selected has been added to the Loan perps + the siblings of that CO
  • Verify that only the prep you selected has been added to the Loan perps
  • Verify that only the prep you selected has been added to the Loan perps
  • Verify that the prep you selected has been added to the Loan perps + all the siblings
  • Verify that only the prep you selected from the non conso has been added to the Loan perps + the prep from the conso COG and all its siblings

Adding COG record sets is working now.

In all the cases the preps are being grouped together only when appropriate 👍👍👍

@CarolineDenis CarolineDenis requested review from sharadsw and removed request for a team December 18, 2024 19:36
@CarolineDenis CarolineDenis requested a review from a team December 18, 2024 20:28
@CarolineDenis CarolineDenis merged commit c2ec0c5 into production Dec 19, 2024
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-5422 branch December 19, 2024 18:36
@grantfitzsimmons
Copy link
Member

grantfitzsimmons commented Dec 19, 2024

@CarolineDenis This PR does not follow the requirements as they were written– can you write a brief summary of what was skipped and why?

Re: #5422

Not for my personal reference, but for the record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add special Consolidated COG Interactions behavior
6 participants