Skip to content

Commit

Permalink
Release builds will use lto = false instead of thin:
Browse files Browse the repository at this point in the history
1. It breaks x86_64-pc-windows-gnullvm target on Windows as with
   llvm optimization it is impossible to link clang libc++
   statically. The gnullvm target is needed as it will link ucrt
   instead of msvc and allow running it without VC runtime. In
   theory it should make a fix possible for:
   kaspanet/rusty-kaspa#417

2. It occasionally lead to node crashes in futures crate,
   especially when mixed with unsafe and C/C++ code. It is hard
   to reproduce, but at least with the from scratch reproduces
   the crash relatively often.
  • Loading branch information
0xA001113 committed Aug 1, 2024
1 parent 198c8a3 commit ced5ce6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,6 @@ workflow-wasm = { version = "0.12.1" }
# nw-sys = { path = "../nw-sys" }

[profile.release]
lto = "thin"
strip = true
overflow-checks = true

Expand Down

0 comments on commit ced5ce6

Please sign in to comment.