Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes io.ReaderAt implementation of mem.File #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bfreis
Copy link

@bfreis bfreis commented May 10, 2022

Adds tests:

  • *mem.File implementation of io.ReaderAt must return non-nil error when reading less than length of give slice.
  • MemMapFs must pass fstest.TestFS tests for non-empty files.

Fixes #352 .

Add tests:
- ``*mem.File` implementation of `io.ReaderAt` must return non-nil error when reading less than length of give slice.
- `MemMapFs` must pass `fstest.TestFS` tests for non-empty files.

Fixes the bug.
@CLAassistant
Copy link

CLAassistant commented May 10, 2022

CLA assistant check
All committers have signed the CLA.

@bfreis bfreis changed the title Fixes #352. Fixes ReaderAt implementation of mem.File May 13, 2022
@bfreis bfreis changed the title Fixes ReaderAt implementation of mem.File Fixes io.ReaderAt implementation of mem.File May 13, 2022
@bfreis
Copy link
Author

bfreis commented May 15, 2022

👋 @mbertschler, @Kargakis

Hey folks, pinging you as I see you merged some PRs recently :)

I have some code commented in tests just waiting for this to get merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: *mem.File violates io.ReaderAt contract
2 participants