Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: partially revert #1387 #1577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sagikazarmark
Copy link
Collaborator

@sagikazarmark sagikazarmark commented Jun 29, 2023

1387 introduced a rather serious breaking change that's causing pain throughout the community. Even though it fixed a buggy behavior the previous one was still useful to a lot of people.

This change introduces a way to revert back to that old behavior by adding a build flag viper_1387.

Fixes #1576

@github-actions
Copy link

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@sagikazarmark sagikazarmark added the release-note/new-feature Release note: Exciting New Features label Jun 29, 2023
1387 introduced a rather serious breaking change that's causing pain
throughout the community. Even though it fixed a buggy behavior
the previous one was still useful to a lot of people.

This change introduces a way to revert back to that old behavior.

Signed-off-by: Mark Sagi-Kazar <[email protected]>
@sagikazarmark
Copy link
Collaborator Author

@ldez @jerome-laforge @b-repo @deynekas Is this something you could work with to get back the previous behavior?

@ldez
Copy link

ldez commented Jun 29, 2023

Hello,

the build tag is a not real solution for us because golangci-lint can be installed with go install or with the "tools" pattern.
So the current PR will not fix our problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature Release note: Exciting New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reverting slice lowercasing to the previous behavior
2 participants