Performance: avoid Object.values call for Array instances

sphinx-doc · Nov 6, 2024 · ab841c6 · ab841c6
1 parent 6b4b675
commit ab841c6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/sphinx/themes/basic/static/searchtools.js b/sphinx/themes/basic/static/searchtools.js
@@ -223,8 +223,12 @@ const Search = {
     while (stack.length) {
       const value = stack.pop();
       if (!(value instanceof Object)) continue;
-      stack.push(...Object.values(value));
-      if (!Array.isArray(value)) Object.setPrototypeOf(value, null);
+      if (Array.isArray(value)) {
+        stack.push(...value);
+      } else {
+        stack.push(...Object.values(value));
+        Object.setPrototypeOf(value, null);
+      }
       Object.freeze(value);
     }
     Search._index = index;