html search: use a Map to collect file-term scores (#13060)

Co-authored-by: Adam Turner <[email protected]>
sphinx-doc · Oct 24, 2024 · bd7d595 · bd7d595
1 parent 70c253e
commit bd7d595
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -18,5 +18,8 @@ Features added
 Bugs fixed
 ----------
 
+* #13060: HTML Search: use ``Map`` to store per-file term scores.
+  Patch by James Addison
+
 Testing
 -------
diff --git a/sphinx/themes/basic/static/searchtools.js b/sphinx/themes/basic/static/searchtools.js
@@ -547,8 +547,9 @@ const Search = {
 
         // set score for the word in each file
         recordFiles.forEach((file) => {
-          if (!scoreMap.has(file)) scoreMap.set(file, {});
-          scoreMap.get(file)[word] = record.score;
+          if (!scoreMap.has(file)) scoreMap.set(file, new Map());
+          const fileScores = scoreMap.get(file);
+          fileScores.set(word, record.score);
         });
       });
 
@@ -587,7 +588,7 @@ const Search = {
         break;
 
       // select one (max) score for the file.
-      const score = Math.max(...wordList.map((w) => scoreMap.get(file)[w]));
+      const score = Math.max(...wordList.map((w) => scoreMap.get(file).get(w)));
       // add result to the result list
       results.push([
         docNames[file],