Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of type annotations with Literal enumeration values #11517

Merged
merged 16 commits into from
Aug 14, 2023

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jul 25, 2023

Fix #11473.

I don't know whether there are more places to be updated so feel free to comment.

@picnixz picnixz marked this pull request as draft July 25, 2023 11:03
@picnixz
Copy link
Member Author

picnixz commented Jul 25, 2023

I'm converting into a draft because I don't know which whould be the best course of action.

I'll present the different possibilities on the issue (let's discuss there).

@picnixz picnixz changed the title Fix rendering of type annotations with Literal enumeration values [DRAFT] Fix rendering of type annotations with Literal enumeration values Jul 25, 2023
@picnixz picnixz force-pushed the fix/11473-literal-enum-rendering branch from 1173b31 to f9d8229 Compare July 26, 2023 09:53
@picnixz picnixz marked this pull request as ready for review July 26, 2023 11:56
@picnixz picnixz changed the title [DRAFT] Fix rendering of type annotations with Literal enumeration values Fix rendering of type annotations with Literal enumeration values Jul 28, 2023
@AA-Turner AA-Turner merged commit 2656f34 into sphinx-doc:master Aug 14, 2023
24 of 26 checks passed
@AA-Turner
Copy link
Member

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enum values inside typing.Literal render weirdly
2 participants