-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML Search: filter script and style elements from search result summary text. #12057
Merged
picnixz
merged 13 commits into
sphinx-doc:master
from
jayaddison:issue-12052/search-result-summary-html-filtering
Mar 17, 2024
Merged
HTML Search: filter script and style elements from search result summary text. #12057
picnixz
merged 13 commits into
sphinx-doc:master
from
jayaddison:issue-12052/search-result-summary-html-filtering
Mar 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… included in HTML search result summary snippets
…included in search result summary text
jayaddison
added
type:bug
html search
javascript
Pull requests that update Javascript code
labels
Mar 9, 2024
… HTML document's <body> element
…xpectedly included in HTML search result summaries
jayaddison
changed the title
HTML search: filter script elements from search result summary text.
HTML search: filter script and style elements from search result summary text.
Mar 9, 2024
jayaddison
changed the title
HTML search: filter script and style elements from search result summary text.
HTML Search: filter script and style elements from search result summary text.
Mar 14, 2024
jayaddison
added
awaiting:response
Waiting for a response from the author of this issue
awaiting:review
PR waiting for a review by a maintainer.
and removed
awaiting:response
Waiting for a response from the author of this issue
labels
Mar 14, 2024
@jayaddison Is this one fine? |
picnixz
approved these changes
Mar 17, 2024
picnixz
added
priority:high
and removed
awaiting:review
PR waiting for a review by a maintainer.
labels
Mar 17, 2024
Yes, this one is ready 👍 Thank you for the review. |
Thank you! |
Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
<script>
and<style>
elements from the summary snippets displayed during search within Sphinx.Detail
Relates
<script>
tags (and maybe others) in search preview #12052.