Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTML search] Tests: cleanup: remove unused function-call arguments. #12628

Merged
merged 1 commit into from
Jul 20, 2024
Merged

[HTML search] Tests: cleanup: remove unused function-call arguments. #12628

merged 1 commit into from
Jul 20, 2024

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Refactoring / cleanup

Purpose

  • Remove a few unused function arguments in the JavaScript search test suite; this makes it easier to correctly alter the underlying function signatures and to write correct test cases that do use them.

Detail

  • N/A

Relates

  • N/A

@jayaddison
[HTML search] Tests: cleanup: remove unused function-call arguments.
7219619 
(cherry picked from commit a7ba9e7)

Conflicts:
	tests/js/searchtools.js
@jayaddison jayaddison added type:tests javascript Pull requests that update Javascript code labels Jul 20, 2024
@AA-Turner AA-Turner merged commit 45f3cd6 into sphinx-doc:master Jul 20, 2024
22 checks passed
@jayaddison
Copy link
Contributor Author

Thanks!

@jayaddison jayaddison deleted the cleanup/remove-unused-js-search-test-args branch July 21, 2024 10:42
@AA-Turner AA-Turner added this to the 8.0.0 milestone Jul 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
html search javascript Pull requests that update Javascript code type:tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jayaddison @AA-Turner