Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use headlessFirefox and update to Node 20 #12794

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

AA-Turner
Copy link
Member

I had a very old branch (AA-Turner@3409085 // https://github.com/AA-Turner/sphinx/commits/use-jasmine/), most of which @jayaddison covered in the recent #12754. This PR takes a few ideas from that branch, such as avoiding xvfb-run as we don't need it, and also updates to the latest node LTS.

A

@AA-Turner AA-Turner enabled auto-merge (squash) August 16, 2024 23:18
@AA-Turner AA-Turner merged commit 2e1415c into sphinx-doc:master Aug 16, 2024
20 of 21 checks passed
@AA-Turner AA-Turner deleted the use-jasmine-2 branch August 16, 2024 23:18
@jayaddison
Copy link
Contributor

Thanks for the mention @AA-Turner - one question: when I search for nodejs in the Ubuntu package directory I find that Ubuntu noble is listed as LTS, and currently distributes NodeJS 18.19.1+dfsg-6ubuntu5. v18 also seems to be Node's current LTS distribution (codename hydrogen, v18.20.4).

Long story short: should we prefer v18 here instead of v20? (and/or maybe make it env.node-version-configurable again?)

@AA-Turner
Copy link
Member Author

The website lists 20 as the latest LTS, as does endoflife.date. Version 18 is security-only.

configurable again

I didn't change env.node-version, I only increased the version number.

A

@jayaddison
Copy link
Contributor

Ok, yep - my mistake; I'd checked the NodeJS readme, but not their website. Filed a small bugreport at nodejs/node#54419 to hopefully clear that up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
@AA-Turner AA-Turner added this to the 8.1.x milestone Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants