Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Hide Update Spicetify Button #866

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

suiminn
Copy link

@suiminn suiminn commented Nov 30, 2024

No description provided.

@suiminn suiminn requested a review from a team as a code owner November 30, 2024 12:05
@suiminn suiminn requested review from theRealPadster and removed request for a team November 30, 2024 12:05
@suiminn suiminn changed the title add Hide Update Spicetify Button feat: add Hide Update Spicetify Button Nov 30, 2024
@theRealPadster
Copy link
Member

What is the point of this? Shouldn't people just update their Spicetify if the button shows up?

@suiminn
Copy link
Author

suiminn commented Nov 30, 2024

I am using Spotify 1.2.13 to utilize the old UI. Since Spicetify versions 2.37.7 and later do not work with Spotify 1.2.13, I need to stick with this version.

@theRealPadster
Copy link
Member

I'm not sure how I feel about making it easy to hide the notification that your Spicetify is out of date. I can see how it would be helpful if you're intentionally using an older version and want to lock things as they are, but for most people, I don't think they'd need this and making it easy to do could result in new users hiding the notification if they don't know how to update or are frustrated if it shows up too often. If you're locking versions manually you're probably advanced enough to be able to add this as a custom snippet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants