-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move towards individual folder manifests #766
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 16.5%, saving 4.54 MB.
35 images did not require optimisation. |
…hemes into generated-manifest
…hemes into generated-manifest
…hemes into generated-manifest
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 4.6%, saving 49.50 KB.
69 images did not require optimisation. |
…hemes into generated-manifest
Yes, it was because of the conflicts as Bloom itself was removed quite some time in
The invalid character appeared on my very first commit to this branch of what appears to be a CI problem where it'd remove the whitespaces from the |
This reverts commit 16a6961.
…b.com:spicetify/spicetify-themes into generated-manifest
Still happening? @afonsojramos |
@OverRevvv I don't know why you're approving this, it's not even close to ready yet? |
Welcome to PR number #766, this will be a big one, so bear with me.
This is something that I've thought about for quite a while and I think it is time that we move towards a centralised manifest point of view. That is, having a manifest in spicetify-themes that holds a readme with images to all themes + themes manifest. We then generate the "master" manifest with all the themes that are present. Think of it as the official DB for Marketplace.
In the end, we will have more granular control of what we display to end-users. And developers will continue to have all of the freedom to develop their themes and extensions within their repositories. In the end, the only change will be that the manifests that are present in the developers repo's will move to this repo.
This PR mostly attempts to fix spicetify/marketplace#111, however, it also ends up fixing spicetify/marketplace#137.
Once this PR is ready for primetime we will have a period where theme developers will be able to create PRs so that when we make the switch from
github topics
tomaster manifest
every theme you love is present!Additionally, I've added an image compression action so that the images we upload here do not occupy as much space.