Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternate name support for the socket #181

Merged
merged 28 commits into from
Feb 5, 2024
Merged

Add alternate name support for the socket #181

merged 28 commits into from
Feb 5, 2024

Conversation

kfox1111
Copy link
Collaborator

@kfox1111 kfox1111 commented Jan 11, 2024

fixes: #177
fixes: #176
fixes: #182

@kfox1111 kfox1111 added the bug Something isn't working label Jan 12, 2024
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR on Openshift in IBM Cloud. All the services started correctly. OIDC works as expected. LGTM

Copy link
Collaborator Author

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version support removed in another pr. Remove from here as well.

charts/spire/charts/spire-agent/README.md Outdated Show resolved Hide resolved
charts/spire/charts/spire-agent/values.yaml Outdated Show resolved Hide resolved
@faisal-memon faisal-memon self-assigned this Jan 16, 2024
@faisal-memon faisal-memon added this to the 0.18.0 milestone Jan 19, 2024
@faisal-memon faisal-memon modified the milestones: 0.18.0, 0.17.1 Jan 30, 2024
@faisal-memon faisal-memon modified the milestones: 0.17.1, 0.18.0 Jan 30, 2024
@faisal-memon faisal-memon merged commit 8adbb89 into main Feb 5, 2024
28 checks passed
@faisal-memon faisal-memon deleted the socket-alias branch February 5, 2024 19:40
faisal-memon added a commit that referenced this pull request Feb 5, 2024
* 49e21c3 Add missing affinity settings (#232)
* 8adbb89 Add alternate name support for the socket (#181)
* 350ec89 Bump test chart dependencies (#235)
* 0e12595 Update README.md delete pvc for cleanup (#233)

Signed-off-by: Faisal Memon <[email protected]>
faisal-memon added a commit that referenced this pull request Feb 5, 2024
* 49e21c3 Add missing affinity settings (#232)
* 8adbb89 Add alternate name support for the socket (#181)
* 350ec89 Bump test chart dependencies (#235)
* 0e12595 Update README.md delete pvc for cleanup (#233)

Signed-off-by: Faisal Memon <[email protected]>
@drewwells
Copy link
Contributor

Is there an image change to address #177? I was expecting to see an environment variable that points to the location of spire-agent config. Something like this will now work?
$ kubectl -n spire-server exec daemonset/spire-agent -- /opt/spire/bin/spire-agent api validate jwt -audience 'us-box-3' -svid '...'

@kfox1111
Copy link
Collaborator Author

kfox1111 commented Feb 5, 2024

The clients don't honor an environment variable unfortunately. Only looking for the socket at the default location.

Something like this should work now:

kubectl -it -n spire-system exec daemonset/spire-agent -- spire-agent api validate jwt -audience 'us-box-3' -svid '...'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

socket rename not cleaned up spire-agent: cli commands do not function as expected socket aliases
4 participants