Add support for signaling an external process via pid file #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kfox1111 Thanks for the submission. The linter is complaining about |
MarcosDY
reviewed
Dec 20, 2023
|
Checking back in on this functionality. How do we get it moving again? |
@kfox1111 Sorry for letting this slip.
|
faisal-memon
force-pushed
the
pidfile
branch
2 times, most recently
from
cbe340b to
8742213
Compare
Signed-off-by: Kevin Fox <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
MarcosDY
approved these changes
Oct 16, 2024
|
This didn't get added to the README. I've added a PR for it here #243 |
ringerc
reviewed
Jan 31, 2025
Comment on lines
+166
to
+169
| if (c.Cmd != "" || c.PIDFileName != "") && c.RenewSignal == "" { | ||
| return errors.New("Must specify renew_signal when using cmd or pid_file_name") | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements: #115