Svidstore gcp region #5718
Merged
Svidstore gcp region #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Hörnström <[email protected]>
Signed-off-by: Jens Hörnström <[email protected]>
jenshornan
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
Signed-off-by: Jens Hörnström <[email protected]>
Co-authored-by: Sorin Dumitru <[email protected]> Signed-off-by: jenshornan <[email protected]>
Signed-off-by: Jens Hörnström <[email protected]>
|
Sorry for failing test. Should be fixed now. |
sorindumitru
reviewed
Jan 3, 2025
sorindumitru
reviewed
Jan 3, 2025
Signed-off-by: Jens Hörnström <[email protected]>
Signed-off-by: Jens Hörnström <[email protected]>
Signed-off-by: Jens Hörnström <[email protected]>
MarcosDY
reviewed
Jan 14, 2025
Signed-off-by: Jens Hörnström <[email protected]>
Signed-off-by: Jens Hörnström <[email protected]>
MarcosDY
approved these changes
Jan 16, 2025
|
I ran the failing unit-test locally and it passes. TestUpstreamProcessTaintedAuthority Running tool: /opt/homebrew/bin/go test -timeout 30s -run ^TestUpstreamProcessTaintedAuthority$ github.com/spiffe/spire/pkg/server/ca/manager ok github.com/spiffe/spire/pkg/server/ca/manager 0.750s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Now you are able to specify the region the secret gets created in
Description of change
Add new selector called region. If no region selector is given it will be the old behavior to create a global secret.
Which issue this PR fixes
fixes #5717