Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up integration test Docker warnings #5762

Merged

Conversation

rturner3
Copy link
Collaborator

@rturner3 rturner3 commented Jan 7, 2025

Docker doesn't like it when Dockerfile keywords on the same line don't match in capitalization, e.g. FROM foo as bar.

Also remove deprecated version property from a Docker Compose file.

Docker doesn't like it when Dockerfile keywords on the same line don't
match in capitalization, e.g. `FROM foo as bar`.

Also remove deprecated `version` property from a Docker Compose file.

Signed-off-by: Ryan Turner <[email protected]>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rturner3 rturner3 added this to the 1.11.2 milestone Jan 14, 2025
@rturner3 rturner3 merged commit 07bfe79 into spiffe:main Jan 15, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants