-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
458: Markdown linter as a local npm script & Git Action execution #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, let's fix some of the lint errors on the pr docs/blogs.md and this should be good to go.
Thanks for taking a look @mamy-CS. |
@adigidh we have a building failure in the frontend please check. https://github.com/spiffe/tornjak/actions/runs/11113268459/job/30918941927?pr=503 |
@adigidh try the following steps to fix the npm authentication error:
|
@mamy-CS :
I think I figured out the issue. Because the project by itself doesn't have a |
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
Signed-off-by: Aditya Gidh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pr @adigidh
/lgtm
fixes #458
Summary of Changes:
.markdownlint.yml
that holds the rules (can be updated based on our requirements)markdownlint-cli2
is the CLI tool that helps us with the script execution.npm run lint
will produce results for the markdown linting errors.npm run lint: fix
will help to auto fix these issues for markdown linting- Uses a custom configuration file
- Runs markdown linter on markdown files in the
docs
directory-
continue-on-error: true
parameter set currently to not fail the github action on every pull request